[ovs-dev] [PATCH] rhel: fix logrotate group when dpdk is enabled

[Ilya Maximets]

On 4/30/19 7:10 PM, Jaime Caamaño Ruiz wrote:
> Otherwise logrotate will fail to generate the rotated log files.
> 
> Signed-off-by: Jaime Caamaño Ruiz <jcaamano at suse.com>
> ---

Hi.  I'm looking through old patches after the patchwork cleanup and this
one seems to be still valid and applicable.

I could apply it if it still needed.  Jaime, what do you think?

Flavio, Aaron, could you, please, take a look at this patch?

Best regards, Ilya Maximets.

>  rhel/openvswitch-fedora.spec.in | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
> index ce728b4f0..01401d5f1 100644
> --- a/rhel/openvswitch-fedora.spec.in
> +++ b/rhel/openvswitch-fedora.spec.in
> @@ -366,18 +366,19 @@ exit 0
>  %post
>  %if %{with libcapng}
>  if [ $1 -eq 1 ]; then
> -    sed -i 's:^#OVS_USER_ID=:OVS_USER_ID=:' /etc/sysconfig/openvswitch
> -    sed -i 's:\(.*su\).*:\1 openvswitch openvswitch:' %{_sysconfdir}/logrotate.d/openvswitch
> -
>  %if %{with dpdk}
> -    sed -i \
> -        's at OVS_USER_ID="openvswitch:openvswitch"@OVS_USER_ID="openvswitch:hugetlbfs"@'\
> -        /etc/sysconfig/openvswitch
> +    %define gname hugetlbfs
> +%else
> +    %define gname openvswitch
>  %endif
> +    sed -i \
> +        's@^#OVS_USER_ID="openvswitch:openvswitch"@OVS_USER_ID="openvswitch:%{gname}"@'\
> +        %{_sysconfdir}/sysconfig/openvswitch
> +    sed -i 's:\(.*su\).*:\1 openvswitch %{gname}:' %{_sysconfdir}/logrotate.d/openvswitch
>  
> -    # In the case of upgrade, this is not needed.
> -    chown -R openvswitch:openvswitch /etc/openvswitch
> -    chown -R openvswitch:openvswitch /var/log/openvswitch
> +    # In the case of upgrade, this is not needed
> +    chown -R openvswitch:openvswitch %{_sysconfdir}/openvswitch
> +    chown -R openvswitch:%{gname} %{_localstatedir}/log/openvswitch
>  fi
>  %endif
>  
>