[ovs-dev] [PATCH 8/8] netdev-offload-tc: Add offload support for sFlow

0-day Robot robot at bytheb.org
Mon Sep 14 11:14:41 UTC 2020


Bleep bloop.  Greetings Chris Mi, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Improper whitespace around control block
#52 FILE: lib/netdev-offload-tc.c:1682:
    NL_NESTED_FOR_EACH_UNSAFE(nla, left, actions) {

ERROR: Improper whitespace around control block
#72 FILE: lib/netdev-offload-tc.c:1702:
    NL_NESTED_FOR_EACH_UNSAFE(nla, left, actions) {

ERROR: Improper whitespace around control block
#95 FILE: lib/netdev-offload-tc.c:1725:
    NL_NESTED_FOR_EACH_UNSAFE(nla, left, actions) {

ERROR: Inappropriate bracing around statement
#106 FILE: lib/netdev-offload-tc.c:1736:
    if (tc_action->sample.action_rate)  {

WARNING: Line is 80 characters long (recommended limit is 79)
#297 FILE: lib/tc.c:1319:
    action->sample.action_rate = nl_attr_get_u32(sample_attrs[TCA_SAMPLE_RATE]);

Lines checked: 392, Warnings: 1, Errors: 4


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list