[ovs-dev] [PATCH ovn v3] ovn-northd: Fix multiple ARP replies for SNAT entries configured on a distributed router.

Numan Siddique numans at ovn.org
Mon Sep 14 17:51:19 UTC 2020


On Mon, Sep 14, 2020 at 10:26 PM Dumitru Ceara <dceara at redhat.com> wrote:

> On 9/14/20 5:46 PM, numans at ovn.org wrote:
> > From: Numan Siddique <numans at ovn.org>
> >
> > The commit in the Fixes tag, while addressing the issue to send ARP
> replies for
> > the SNAT entries, didn't take into account the gateway router port
> scenario.
> > Because of this, all the chassis which have bridge mappings configured
> reply
> > to ARP request for SNAT entries. This patch fixes the issue by adding
> > "is_chassis_resident()" condition for such flows so that only the
> gateway chassis
> > which claims the gateway router port responds to the ARP request.
> >
> > Note: This patch doesn't require any changes to ovn-northd.8.xml as it
> was already
> > documented with the desired flows for SNAT entries.
> >
> > Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2020-September/050679.html
> > Reported-by: Chris <kklimonda at syntaxhighlighted.com>
> > Fixes: e2aa124ff7c2("ovn-northd: Add ARP responder flows for SNAT
> entries.")
> > Signed-off-by: Numan Siddique <numans at ovn.org>
> > ---
> > v2 -> v2
> > ------
> >  * Address review comments. Added a TODO.rst entry and remove the gw
> >    router port check while adding SNAT priority-100 lflows.
> >
> > v1 -> v2
> > ---
> >  * Address review comments from Dumitru.
> >
> >  TODO.rst            |   4 +
> >  northd/ovn-northd.c |  14 ++-
> >  tests/ovn-northd.at |   5 +
> >  tests/ovn.at        | 260 ++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 279 insertions(+), 4 deletions(-)
> >
> > diff --git a/TODO.rst b/TODO.rst
> > index 4b2fc2d01..328e0b875 100644
> > --- a/TODO.rst
> > +++ b/TODO.rst
> > @@ -25,6 +25,10 @@
> >  OVN To-do List
> >  ==============
> >
> > +* Refactor ovn-northd code to have a separate functions to add logical
> flows
>
> Nit: s/a separate/separate
>
> With this addressed:
> Acked-by: Dumitru Ceara <dceara at redhat.com>
>

Thanks for the reviews Dumitru. with the typo fixed, I applied this patch
to master and branch-20.06.

Thanks
Numan


>
> Thanks,
> Dumitru
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>


More information about the dev mailing list