[ovs-dev] [PATCH 2/2] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

Gregory Rose gvrose8192 at gmail.com
Mon Sep 14 20:11:05 UTC 2020


On 9/14/2020 10:24 AM, Ilya Maximets wrote:
> On 9/11/20 5:37 PM, Gregory Rose wrote:
>>
>> On 10/14/2019 9:51 PM, wenxu wrote:
>>>
>>> On 10/15/2019 5:14 AM, Gregory Rose wrote:
>>>>
>>>>
>>>> On 10/8/2019 4:51 PM, Greg Rose wrote:
>>>>> From: wenxu <wenxu at ucloud.cn>
>>>>>
>>>>> Upstream commit:
>>>>>        commit 18b6f717483a835fb98de9f0df6c724df9324e78
>>>>>        Author: wenxu <wenxu at ucloud.cn>
>>>>>        Date:   Thu Mar 28 12:43:23 2019 +0800
>>>>>
>>>>>        openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode
>>>>>
>>>>>        There is currently no support for the multicast/broadcast aspects
>>>>>        of VXLAN in ovs. In the datapath flow the tun_dst must specific.
>>>>>        But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specific.
>>>>>        And the packet can forward through the fdb table of vxlan devcice. In
>>>>>        this mode the broadcast/multicast packet can be sent through the
>>>>>        following ways in ovs.
>>>>>
>>>>>        ovs-vsctl add-port br0 vxlan -- set in vxlan type=vxlan \
>>>>>                options:key=1000 options:remote_ip=flow
>>>>>        ovs-ofctl add-flow br0 in_port=LOCAL,dl_dst=ff:ff:ff:ff:ff:ff, \
>>>>>                action=output:vxlan
>>>>>
>>>>>        bridge fdb append ff:ff:ff:ff:ff:ff dev vxlan_sys_4789 dst 172.168.0.1 \
>>>>>                src_vni 1000 vni 1000 self
>>>>>        bridge fdb append ff:ff:ff:ff:ff:ff dev vxlan_sys_4789 dst 172.168.0.2 \
>>>>>                src_vni 1000 vni 1000 self
>>>>>
>>>>>        Signed-off-by: wenxu <wenxu at ucloud.cn>
>>>>>        Acked-by: Pravin B Shelar <pshelar at ovn.org>
>>>>>        Signed-off-by: David S. Miller <davem at davemloft.net>
>>>>>
>>>>> Also fixup case statement in lib/odp-util.c to make the compiler happy.
>>>>>
>>>>> Cc: wenxu <wenxu at ucloud.cn>
>>>>> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
>>>>
>>>> Hi Wenxu,
>>>>
>>>> would you mind giving this patch a review - I just want to make sure I didn't miss anything.
>>>>
>>>> Thanks,
>>>>
>>>> - Greg
>>>>
>>> Looks good to me!
>>>
>>>
>>> Thanks
>>>
>>> wenxu
>>>
>>
>> Maintainers,
>>
>> I submited these patches back in October 2019 and then never got further
>> with them.  Since then the patch set is moribund I guess but I'm wondering if I should resubmit?
> 
> Hi.  Yes, it'll be great if you can re-submit at least to check that it still
> applicable and up to date.
> 
> Regarding this feature (IP_TUNNEL_INFO_BRIDGE) I also reviewed the userspace
> part last week, but had no reply so far.  And so I'm not sure if anyone will
> actually continue to work on this userspace part:
>    https://mail.openvswitch.org/pipermail/ovs-dev/2020-September/374733.html

Well the kernel bits make no sense without the userspace bits.  Let
me see if I can advance both.  Busy with some other stuff but should get
back to this soon.  I'll resubmit the kernel and the userspace patches
together and copy wenxu when I do.

- Greg



More information about the dev mailing list