[ovs-dev] [PATCH ovn v2] ovn-northd: Fix router policy pkt mark over flow if the value is greater than signed int.

Dumitru Ceara dceara at redhat.com
Fri Sep 18 15:34:07 UTC 2020


On 9/18/20 5:29 PM, numans at ovn.org wrote:
> From: Numan Siddique <numans at ovn.org>
> 
> If the value of pkt_mark in the router policy options is greater than 2147483647, we
> are ignoring it. This is because we use smap_get_int(). This patch fixes this issue
> by adding a wrapper function - ovn_smap_get_uint(). The OpenvSwitch library doesn't have
> this smap helper function.
> 
> ovn_smap_get_uint() needs to be removed once the OpenvSwitch library has this helper
> function. A comment has been added in the code for this.
> 
> Fixes: a123ef0fb8fd("Support packet metadata marking for logical router policies.")
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1878248
> Reported-by: Alexander Constantinescu <aconstan at redhat.com>
> Signed-off-by: Numan Siddique <numans at ovn.org>
> ---

Looks good to me.

Acked-by: Dumitru Ceara <dceara at redhat.com>

Thanks,
Dumitru



More information about the dev mailing list