[ovs-dev] [PATCH v8] dpif-netlink: distribute polling to discreet handlers

Mark Gray mark.d.gray at redhat.com
Mon Sep 21 08:55:50 UTC 2020


On 18/09/2020 18:53, Flavio Leitner wrote:
> On Fri, Sep 18, 2020 at 05:31:30PM +0100, Mark Gray wrote:
>> On 17/09/2020 20:49, Aaron Conole wrote:
>>> Ilya Maximets <i.maximets at ovn.org> writes:

>>>> What is the reason of having this pool?  Datapath port numbers are unique
>>>> except for ODPP_NONE, and all the functions you implemented actually
>>>> iterates over all channels anyway to find one with requested port_idx.
>>>> So, the only purpose of it is to avoid searching on incorect port number,
>>>> but this should be a rare case.  Can we just remove it?
>>>>
>>>> OTOH, if it's necessary to have this id pool, I'd suggest to use hmapx
>>>> instead as it already has all required infrastructure and doesn't actually
>>>> care about range of values.
>>
>> I have replaced this with a hmap of all the channels as suggested in
>> another thread by Flavio.
> 
> I think Ilya is referring to id_pool, not the hmap used for the
> channels.
> 
> 

Yes, I have replaced the id_pool. I have sent out a v9.



More information about the dev mailing list