[ovs-dev] 答复: [PATCH] ofproto-dpif-xlate: Stop forwarding MLD reports to group ports.

[dingxiaoxiong]

I am a litter busy on my project right now , I suppose to add the test case after a while.

-----邮件原件-----
发件人: dingxiaoxiong 
发送时间: 2020年9月29日 16:31
收件人: dev at openvswitch.org
抄送: fbl at sysclose.org; Guohongzhi (Russell Lab) <guohongzhi1 at huawei.com>; dingxiaoxiong <dingxiaoxiong at huawei.com>
主题: [PATCH] ofproto-dpif-xlate: Stop forwarding MLD reports to group ports.

According with rfc4541 section 2.1.1, 
a snooping switch should forward membership reports only 
to ports with routers attached.
The current code violates the RFC forwarding membership 
reports to group ports as well.
The same issue doesn't exist with IPv4.

Fixes: 06994f879c ("mcast-snooping: Add Multicast Listener Discovery support")
Signed-off-by: XiaoXiong Ding <dingxiaoxiong at huawei.com>
---
 ofproto/ofproto-dpif-xlate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index e0ede2cab..47571e790 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -3100,6 +3100,7 @@ xlate_normal(struct xlate_ctx *ctx)
                 xlate_report(ctx, OFT_DETAIL, "MLD query, flooding");
                 xlate_normal_flood(ctx, in_xbundle, &xvlan);
             }
+            return;
         } else {
             if (is_ip_local_multicast(flow, wc)) {
                 /* RFC4541: section 2.1.2, item 2: Packets with a dst IP
-- 
2.14.1.windows.1