[ovs-dev] [PATCH V3 15/24] datapath: fix flow command message size

Yi-Hung Wei yihung.wei at gmail.com
Tue Sep 29 21:44:12 UTC 2020


On Wed, Sep 16, 2020 at 10:39 AM Greg Rose <gvrose8192 at gmail.com> wrote:
>
> From: Paolo Abeni <pabeni at redhat.com>
>
> Upstream commit:
>     commit 4e81c0b3fa93d07653e2415fa71656b080a112fd
>     Author: Paolo Abeni <pabeni at redhat.com>
>     Date:   Tue Nov 26 12:55:50 2019 +0100
>
>     openvswitch: fix flow command message size
>
>     When user-space sets the OVS_UFID_F_OMIT_* flags, and the relevant
>     flow has no UFID, we can exceed the computed size, as
>     ovs_nla_put_identifier() will always dump an OVS_FLOW_ATTR_KEY
>     attribute.
>     Take the above in account when computing the flow command message
>     size.
>
>     Fixes: 74ed7ab9264c ("openvswitch: Add support for unique flow IDs.")
>     Reported-by: Qi Jun Ding <qding at redhat.com>
>     Signed-off-by: Paolo Abeni <pabeni at redhat.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Cc: Paolo Abeni <pabeni at redhat.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---
LGTM

Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>


More information about the dev mailing list