[ovs-dev] [PATCH V3 16/24] datapath: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()

Yi-Hung Wei yihung.wei at gmail.com
Wed Sep 30 22:37:06 UTC 2020


On Wed, Sep 16, 2020 at 10:34 AM Greg Rose <gvrose8192 at gmail.com> wrote:
>
> From: Paolo Abeni <pabeni at redhat.com>
>
> Upstream commit:
>     commit 8ffeb03fbba3b599690b361467bfd2373e8c450f
>     Author: Paolo Abeni <pabeni at redhat.com>
>     Date:   Sun Dec 1 18:41:24 2019 +0100
>
>     openvswitch: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()
>
>     All the callers of ovs_flow_cmd_build_info() already deal with
>     error return code correctly, so we can handle the error condition
>     in a more gracefull way. Still dump a warning to preserve
>     debuggability.
>
>     v1 -> v2:
>      - clarify the commit message
>      - clean the skb and report the error (DaveM)
>
>     Fixes: ccb1352e76cf ("net: Add Open vSwitch kernel components.")
>     Signed-off-by: Paolo Abeni <pabeni at redhat.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Cc: Paolo Abeni <pabeni at redhat.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---

Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>


More information about the dev mailing list