[ovs-dev] [PATCH V3 17/24] datapath: remove another BUG_ON()

Yi-Hung Wei yihung.wei at gmail.com
Wed Sep 30 22:37:13 UTC 2020


On Wed, Sep 16, 2020 at 10:36 AM Greg Rose <gvrose8192 at gmail.com> wrote:
>
> From: Paolo Abeni <pabeni at redhat.com>
>
> Upstream commit:
>     commit 8a574f86652a4540a2433946ba826ccb87f398cc
>     Author: Paolo Abeni <pabeni at redhat.com>
>     Date:   Sun Dec 1 18:41:25 2019 +0100
>
>     openvswitch: remove another BUG_ON()
>
>     If we can't build the flow del notification, we can simply delete
>     the flow, no need to crash the kernel. Still keep a WARN_ON to
>     preserve debuggability.
>
>     Note: the BUG_ON() predates the Fixes tag, but this change
>     can be applied only after the mentioned commit.
>
>     v1 -> v2:
>      - do not leak an skb on error
>
>     Fixes: aed067783e50 ("openvswitch: Minimize ovs_flow_cmd_del critical section.")
>     Signed-off-by: Paolo Abeni <pabeni at redhat.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Cc: Paolo Abeni <pabeni at redhat.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---

Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>


More information about the dev mailing list