[ovs-dev] [PATCH v4] netlink: ignore IFLA_WIRELESS events

[Michał Kazior]

On Thu, 1 Apr 2021 at 21:17, Ilya Maximets <i.maximets at ovn.org> wrote:
> On 3/4/21 4:32 PM, Michal Kazior wrote:
[...]
> It's unclear why we need to check inside these functions.
> I mean, there is only one place where these functions called
> and there is no any useful work done there beside calling them.
> I think, it's better to just check right after receiving
> the change in a same way as in netdev_linux_update_via_netlink().
>
> Something like this:
>
[...]
> -            if (rtnetlink_parse(&buf, &change)) {
> +            if (rtnetlink_parse(&buf, &change) && !change->irrelevant) {
[...]
>
> What do you think?
> If it looks good to you, I can squash above diff with your patch and
> apply to master.

No particular reason why I did it like that. But you're right. I don't
mind if you change it. Thanks!


Michał