[ovs-dev] [PATCH ovn] ovn-sbctl: Add logical flows count numbers

0-day Robot robot at bytheb.org
Mon Apr 12 09:59:33 UTC 2021


Bleep bloop.  Greetings Alexey Roytman, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line has trailing whitespace
#70 FILE: utilities/ovn-sbctl.8.in:211:
and  

WARNING: Line has trailing whitespace
#71 FILE: utilities/ovn-sbctl.8.in:212:
.IP "[\fB\-\-count\fR] \fBdump\-flows\fR [\fIlogical-datapath\fR]" 

WARNING: Line has trailing whitespace
#73 FILE: utilities/ovn-sbctl.8.in:214:
.  

WARNING: Line has trailing whitespace
#86 FILE: utilities/ovn-sbctl.c:1118:
print_datapath_prompt(const struct sbrec_datapath_binding *dp, 

WARNING: Line has trailing whitespace
#87 FILE: utilities/ovn-sbctl.c:1119:
                      const struct uuid *uuid, 

ERROR: Improper whitespace around control block
#116 FILE: utilities/ovn-sbctl.c:1148:
        if ( prev && (prev->lflow->table_id != curr->lflow->table_id || new_datapath )) {

ERROR: Improper whitespace around control block
ERROR: Inappropriate bracing around statement
#119 FILE: utilities/ovn-sbctl.c:1151:
            if ( new_datapath ) {

ERROR: Improper whitespace around control block
ERROR: Inappropriate bracing around statement
#130 FILE: utilities/ovn-sbctl.c:1162:
        if ( new_datapath ) {

ERROR: Improper whitespace around control block
#135 FILE: utilities/ovn-sbctl.c:1167:
    if ( n_flows > 0) {

ERROR: Improper whitespace around control block
ERROR: Inappropriate bracing around statement
#149 FILE: utilities/ovn-sbctl.c:1236:
    if ( shash_find(&ctx->options, "--count") != NULL ) {

Lines checked: 192, Warnings: 5, Errors: 8


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list