[ovs-dev] [PATCH branch-2.14 2/3] netdev-offload-tc: Probe for support for any of the ct_state flags

[Aaron Conole]

Marcelo Leitner <marcelo.leitner at gmail.com> writes:

> On Fri, Apr 09, 2021 at 09:35:04AM -0400, Aaron Conole wrote:
>> +static int
>> +probe_insert_ct_state_rule(int ifindex, uint16_t ct_state, struct tcf_id *id)
>> +{
>> +    int prio = TC_RESERVED_PRIORITY_MAX + 1;
>> +    struct tc_flower flower;
>> +
>> +    memset(&flower, 0, sizeof flower);
>> +    flower.key.ct_state = ct_state;
>> +    flower.mask.ct_state = ct_state;
>> +    flower.tc_policy = TC_POLICY_SKIP_HW;
>
> This field is introduced in patch 3/3 here and with that, if doing a
> bisect or so, the line above will fail to compile. It's best if patch
> 3 is moved to the front of the patchset, like it is on the 2.13
> patchset.

Oops... I had moved them, but forgot to regenerate the series.  I'll
repost 2.14 branch.

> Btw, I liked how the backports are going to be probe for the new
> features but not use them. That might give useful debugging
> information later on.
>
>   Marcelo