[ovs-dev] [PATCH ovn v2] controller: Monitor all logical flows that refer to datapath groups.

Dumitru Ceara dceara at redhat.com
Mon Apr 19 07:27:08 UTC 2021


On 4/16/21 7:16 PM, Mark Michelson wrote:
> Thanks for the explanation Dumitru. It made good sense out of what had
> to be a difficult thing to debug. I'm assuming you went with
> unconditional monitoring since this will work with any change to a DP
> group, and not just the addition new datapaths to the group.

There's also a case I didn't mention in the commit log (but I can add it
if you think it's worth adding):

If a logical flow LF1 is not shared between datapaths, so it's only
applied to DP1, when DP2 is added that needs an identical flow,
ovn-northd might generate a fresh new DPG = {.datapaths=[DP1, DP2]}, and
create a new LF1' applied on datapath_group=DPG.

Without unconditional monitoring for datapath groups there's no easy way
to get the notification about DPG and LF1' being added in the same
jsonrpc update from SB with the delete for LF.

Given that the number of datapath groups is expected to be relatively
low compared to the total number of logical flows, unconditional
monitoring seems like the best solution.

> 
> Acked-by: Mark Michelson <mmichels at redhat.com>

Thanks!



More information about the dev mailing list