[ovs-dev] [PATCH v2] dpif-netlink: fix using uninitialized info.tc_modify_flow_deleted in out label

[Ilya Maximets]

On 4/9/21 1:28 PM, Simon Horman wrote:
> On Thu, Apr 08, 2021 at 09:33:12PM +0800, wangyunjian wrote:
>> From: Yunjian Wang <wangyunjian at huawei.com>
>>
>> Before info.tc_modify_flow_deleted is assigned a value, error
>> processing of other statements goes to the out label. In the
>> out label, the uninitialized variant is used for condition
>> determination, which may cause uncertain behavior.
>>
>> Fixes: 65b84d4a32bd ("dpif-netlink: avoid netlink modify flow put op failed after tc modify flow put op failed.")
>> Signed-off-by: Mengfan Lv <lvmengfan at huawei.com>
>> Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> 
> Thanks, I see the problem you describe and agree
> it is wise to take the approach of initialising this as early as possible.
> 
> Reviewed-by: Simon Horman <simon.horman at netronome.com>

Thanks!  Applied to master and backported down to 2.13.

Best regards, Ilya Maximets.