[ovs-dev] [PATCH v2] conntrack: document NULL SNAT behavior and add a test case

Ilya Maximets i.maximets at ovn.org
Wed Apr 21 14:06:05 UTC 2021


On 3/30/21 2:25 PM, Eelco Chaudron wrote:
> Currently, conntrack in the kernel has an undocumented feature referred
> to as NULL SNAT. Basically, when a source port collision is detected
> during the commit, the source port will be translated to an ephemeral
> port. If there is no collision, no SNAT is performed.
> 
> This patchset documents this behavior and adds a self-test to verify
> it's not changing.
> 
> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
> ---
> v2: Fixed NULL SNAT to only work in the -rpl state to be inline with
>     OpenShift-SDN's behavior.
> 
>  lib/ovs-actions.xml              |   10 ++++++++
>  tests/system-kmod-macros.at      |    7 ++++++
>  tests/system-traffic.at          |   46 ++++++++++++++++++++++++++++++++++++++
>  tests/system-userspace-macros.at |   10 ++++++++
>  4 files changed, 73 insertions(+)

As per comment from Ben for v2 of Paolo's patch, I think we need
to avoid usage of NULL in this patch too:

  https://patchwork.ozlabs.org/project/openvswitch/patch/161721063438.355752.4375787531104430414.stgit@fed.void/

Best regards, Ilya Maximets.


More information about the dev mailing list