[ovs-dev] [PATCH v2 10/11] conntrack: Do not log empty ct-sweep

Gaetan Rivet grive at u256.net
Wed Apr 21 22:11:24 UTC 2021


Do not add noise to the DBG log for empty sweeps.
Only log time taken when some connections were cleaned.

Signed-off-by: Gaetan Rivet <grive at u256.net>
Reviewed-by: Eli Britstein <elibr at nvidia.com>
---
 lib/conntrack.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/conntrack.c b/lib/conntrack.c
index 8a7538b7b..823fb060a 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -1647,8 +1647,10 @@ ct_sweep(struct conntrack *ct, long long now, size_t limit)
     }
 
 out:
-    VLOG_DBG("conntrack cleanup %"PRIuSIZE" entries in %lld msec", count,
-             time_msec() - now);
+    if (count > 0) {
+        VLOG_DBG("conntrack cleanup %"PRIuSIZE" entries in %lld msec", count,
+                 time_msec() - now);
+    }
     return min_expiration;
 }
 
-- 
2.31.1



More information about the dev mailing list