[ovs-dev] [PATCH] conntrack: remove the nat_action_info from the conn

Gaëtan Rivet grive at u256.net
Wed Aug 11 00:19:44 UTC 2021


On Thu, Aug 5, 2021, at 05:11, wenxu at ucloud.cn wrote:
> From: wenxu <wenxu at ucloud.cn>

Hi Wenxu,

A few nits in the commit log, otherwise the change looks good to me.

> 
> Only the nat_action in the nat_action_info is used for conn
> packet forward and other item such as min/max_ip/port only 
> used for the new conn operation. So the whole nat_ction_info
> no need store in conn. This will also avoid unnecessary memory
> allocation.

Suggested rewrite:

Only 'nat_action_info->nat_action' is used for packet forwarding.
Other items such as min/max_ip/port are used only when creating
new connections. No need to store the whole nat_action_info in conn.

> 
> Signed-off-by: wenxu <wenxu at ucloud.cn>

Acked-by: Gaetan Rivet <grive at u256.net>

Thanks,
-- 
Gaetan Rivet


More information about the dev mailing list