[ovs-dev] [PATCH 2/3] dpif-netdev-unixctl.man: Document miniflow-parser-* CMDs

Stokes, Ian ian.stokes at intel.com
Thu Aug 12 14:46:16 UTC 2021


> Fixes: 3d8f47bc041a ("dpif-netdev: Add command line and function pointer for
> miniflow extract")
> Signed-off-by: Cian Ferriter <cian.ferriter at intel.com>

Hi Cian, as before a one line summary line in the message body would be appreciated.

> ---
>  lib/dpif-netdev-unixctl.man | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man
> index c44c7eaa0..ceb107f90 100644
> --- a/lib/dpif-netdev-unixctl.man
> +++ b/lib/dpif-netdev-unixctl.man
> @@ -247,3 +247,13 @@ Lists the DPIF implementations that are available.
>  .
>  .IP "\fBdpif-netdev/dpif-impl-set\fR \fIdpif_impl\fR"
>  Sets the DPIF to be used to \fIdpif_impl\fR. By default "dpif_scalar" is used.
> +.
> +.IP "\fBdpif-netdev/miniflow-parser-get\fR
> +Lists the miniflow extract implementations that are available.
> +.
> +.IP "\fBdpif-netdev/miniflow-parser-set\fR [\fB-pmd\fR \fIcore\fR] \
> +\fIminiflow_impl\fR [\fIstudy_cnt\fR]"
> +Sets the miniflow extract to be used for one or all pmd threads to

Would maybe re-word this to sets the miniflow extract to be used for a specified PMD or all PMDs in the case where no value is specified.

Just to make it clear the behavior if the argument is not provided.

BR
Ian

> +\fIminiflow_impl\fR.  By default "scalar" is used. \fIstudy_cnt\fR defaults to
> +128 and indicates the number of packets that the "study" miniflow
> +implementation must parse before choosing an optimal implementation.
> --
> 2.32.0
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list