[ovs-dev] [PATCH] netdev-offload-dpdk: initialize s_tnl dynamic string

[Ilya Maximets]

On 8/14/21 7:30 AM, Sriharsha Basavapatna via dev wrote:
> On Fri, Aug 13, 2021 at 6:27 PM Gaëtan Rivet <grive at u256.net> wrote:
> 
>> On Fri, Aug 13, 2021, at 08:14, Sriharsha Basavapatna via dev wrote:
>>> The 's_tnl' member in flow_patterns and flow_actions should be
>>> to set to DS_EMPTY_INITIALIZER, to be consistent with dynamic string
>>> initializations.
>>>
>>> Also, there's a potential memory leak of flow_patterns->s_tnl.
>>> Fix this by destroying s_tnl in free_flow_patterns().
>>>
>>> Fixes: 507d20e77bfe ("netdev-offload-dpdk: Support vports flows
>> offload.")
>>> Fixes: be56e063d028 ("netdev-offload-dpdk: Support tunnel pop action.")
>>> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com
>>>
>>
>> Hi Harsha,
>>
>> Thanks for the fix. I have an optional remark below.
>> However, I'm not sure it's worth sending a v2 for it, so
>> whether it's integrated as-is or modified is fine.
>>
>> Acked-by: Gaetan Rivet <grive at u256.net>
>>
>>
> Thanks Gaetan, I'll not send out a v2 for this change.

Thanks!  I added some commas and applied to master and branch 2.16.

Best regards, Ilya Maximets.