[ovs-dev] [OVN Patch v3 3/3] northd: Optimize dp groups operations

0-day Robot robot at bytheb.org
Thu Aug 26 17:42:56 UTC 2021


Bleep bloop.  Greetings Anton Ivanov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#40 FILE: northd/ovn-northd.c:4312:
static void ovn_lflow_destroy(struct lflow_state *lflows, struct ovn_lflow *lflow);

WARNING: Line is 90 characters long (recommended limit is 79)
#65 FILE: northd/ovn-northd.c:4388:
        old_lflow = do_ovn_lflow_find(&lflow_map->single_od, NULL, stage, priority, match,

WARNING: Line is 91 characters long (recommended limit is 79)
#73 FILE: northd/ovn-northd.c:4396:
                    hmap_insert_fast(&lflow_map->multiple_od, &old_lflow->hmap_node, hash);

WARNING: Line is 86 characters long (recommended limit is 79)
#75 FILE: northd/ovn-northd.c:4398:
                    hmap_insert(&lflow_map->multiple_od, &old_lflow->hmap_node, hash);

WARNING: Line is 96 characters long (recommended limit is 79)
#80 FILE: northd/ovn-northd.c:4403:
            old_lflow = do_ovn_lflow_find(&lflow_map->multiple_od, NULL, stage, priority, match,

WARNING: Line is 82 characters long (recommended limit is 79)
#145 FILE: northd/ovn-northd.c:4523:
        do_ovn_lflow_find(&lflows->single_od, od, stage, priority, match, actions,

WARNING: Line is 83 characters long (recommended limit is 79)
#148 FILE: northd/ovn-northd.c:4526:
        lflow = do_ovn_lflow_find(&lflows->multiple_od, od, stage, priority, match,

WARNING: Line is 84 characters long (recommended limit is 79)
#613 FILE: northd/ovn-northd.c:8427:
build_ecmp_routing_policy_flows(struct lflow_state *lflows, struct ovn_datapath *od,

WARNING: Line is 80 characters long (recommended limit is 79)
#667 FILE: northd/ovn-northd.c:9428:
build_lswitch_flows_for_lb(struct ovn_northd_lb *lb, struct lflow_state *lflows,

WARNING: Line is 80 characters long (recommended limit is 79)
#685 FILE: northd/ovn-northd.c:9525:
build_lrouter_flows_for_lb(struct ovn_northd_lb *lb, struct lflow_state *lflows,

WARNING: Line is 83 characters long (recommended limit is 79)
#748 FILE: northd/ovn-northd.c:9994:
build_lrouter_force_snat_flows(struct lflow_state *lflows, struct ovn_datapath *od,

WARNING: Line is 82 characters long (recommended limit is 79)
#820 FILE: northd/ovn-northd.c:10516:
build_ND_RA_flows_for_lrouter(struct ovn_datapath *od, struct lflow_state *lflows)

WARNING: Line is 86 characters long (recommended limit is 79)
#874 FILE: northd/ovn-northd.c:10763:
routable_addresses_to_lflows(struct lflow_state *lflows, struct ovn_port *router_port,

WARNING: Line is 85 characters long (recommended limit is 79)
#892 FILE: northd/ovn-northd.c:11127:
build_icmperr_pkt_big_flows(struct ovn_port *op, int mtu, struct lflow_state *lflows,

WARNING: Line is 81 characters long (recommended limit is 79)
#901 FILE: northd/ovn-northd.c:11220:
                                  struct lflow_state *lflows, struct hmap *ports,

WARNING: Line is 81 characters long (recommended limit is 79)
#991 FILE: northd/ovn-northd.c:12041:
build_lrouter_in_unsnat_flow(struct lflow_state *lflows, struct ovn_datapath *od,

WARNING: Line is 82 characters long (recommended limit is 79)
#1009 FILE: northd/ovn-northd.c:12191:
build_lrouter_out_undnat_flow(struct lflow_state *lflows, struct ovn_datapath *od,

WARNING: Line is 80 characters long (recommended limit is 79)
#1018 FILE: northd/ovn-northd.c:12238:
build_lrouter_out_snat_flow(struct lflow_state *lflows, struct ovn_datapath *od,

WARNING: Line is 84 characters long (recommended limit is 79)
#1036 FILE: northd/ovn-northd.c:12467:
build_lrouter_nat_defrag_and_lb(struct ovn_datapath *od, struct lflow_state *lflows,

WARNING: Line is 85 characters long (recommended limit is 79)
#1083 FILE: northd/ovn-northd.c:12935:
                                struct hmap *port_groups, struct lflow_state *lflows,

WARNING: Line is 85 characters long (recommended limit is 79)
#1101 FILE: northd/ovn-northd.c:12971:
                fast_hmap_init(&lflow_segs[index].single_od, lflows->single_od.mask);

WARNING: Line is 80 characters long (recommended limit is 79)
#1112 FILE: northd/ovn-northd.c:12996:
                          &lflows->single_od, lflow_segs, lflow_merge_callback);

Lines checked: 1352, Warnings: 22, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list