[ovs-dev] [PATCH] tests: Skip netlink policy test on non-Linux platforms.

Frode Nordahl frode.nordahl at canonical.com
Sat Aug 28 05:49:26 UTC 2021


lør. 28. aug. 2021, 03:57 skrev Ilya Maximets <i.maximets at ovn.org>:

> FreeBSD tests in Cirrus CI are broken and, I guess, windows tests too:
>
>   89. library.at:258: testing netlink policy ...
>   ./library.at:259: ovstest test-netlink-policy ll_addr
>   --- /dev/null 2021-08-20 19:02:41.907547000 +0000
>   +++ /tmp/cirrus-ci-build/tests/testsuite.dir/at-groups/89/stderr
>   @@ -0,0 +1 @@
>   +ovstest: unknown command 'test-netlink-policy'; use --help for help
>   ./library.at:259: exit code was 1, expected 0
>   89. library.at:258: 89. netlink policy (library.at:258): FAILED
>
> 'tests/test-netlink-policy.c' is built only on Linux, test
> must be skipped on all other platforms to unblock CI.
>

Sorry about that, forgot about our non-linux friends and only looked at
GitHub Actions and local tests.

Acked-by: Frode Nordahl <frode.nordahl at canonical.com>

--
Frode Nordahl


> CC: Frode Nordahl <frode.nordahl at canonical.com>
> Fixes: bfee9f6c0115 ("netlink: Add support for parsing link layer
> address.")
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> ---
>  tests/library.at | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/library.at b/tests/library.at
> index 1ed2ad3e9..b2914ae6c 100644
> --- a/tests/library.at
> +++ b/tests/library.at
> @@ -256,5 +256,7 @@ AT_CHECK([ovstest test-stopwatch], [0], [......
>  AT_CLEANUP
>
>  AT_SETUP([netlink policy])
> +AT_SKIP_IF([test "$IS_WIN32" = "yes"])
> +AT_SKIP_IF([test "$IS_BSD" = "yes"])
>  AT_CHECK([ovstest test-netlink-policy ll_addr], [0])
>  AT_CLEANUP
> --
> 2.31.1
>
>


More information about the dev mailing list