[ovs-dev] [PATCH] github: Don't fail the job if 'apt update' failed.

David Marchand david.marchand at redhat.com
Mon Feb 1 14:12:45 UTC 2021


On Mon, Feb 1, 2021 at 12:56 PM Ilya Maximets <i.maximets at ovn.org> wrote:
>
> Some repositories that are enabled in GHA are not stable and lead
> to 'apt update' failures:
>
>   E: The repository
>      'https://apt.postgresql.org/pub/repos/apt bionic-pgdg Release'
>      no longer has a Release file.
>
> This causes the job failure.
> In most cases we don't really need any packages from these failed
> repositories, so we could try to continue the job.
>
> Proviously this kind of failures happened on older branches with

Nit: Previously*

> ubuntu 16.04 base image, so we have this workaround already there.
> Now it started to fail on bionic images, so fixing there too.
>
> Fixes: 02f76fb42ae9 ("github: Fix Ubuntu package installation.")
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> ---
>  .github/workflows/build-and-test.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
> index e24970505..1bb72bbb1 100644
> --- a/.github/workflows/build-and-test.yml
> +++ b/.github/workflows/build-and-test.yml
> @@ -136,7 +136,7 @@ jobs:
>          key:  ${{ env.matrix_key }}-${{ env.ci_key }}
>
>      - name: update APT cache
> -      run:  sudo apt update
> +      run:  sudo apt update || true
>      - name: install common dependencies
>        if:   matrix.deb_package == ''
>        run:  sudo apt install -y ${{ env.dependencies }}
> --
> 2.26.2
>

Acked-by: David Marchand <david.marchand at redhat.com>

We just had the same failure with ovsrobot/dpdk.
https://github.com/ovsrobot/dpdk/runs/1805805661?check_suite_focus=true#step:7:68

Do you want to send the fix for DPDK?


-- 
David Marchand



More information about the dev mailing list