[ovs-dev] [PATCH 0/2] Add offload support for ct_state rpl and inv flags

[Ilya Maximets]

On 2/2/21 4:52 PM, wenxu wrote:
> 
> Hi,
> 
> just ingore my patch. Now kernel can support match invalid
> ct_state in th tc flower.

I don't think that we can ignore it.  At least we need this
fix on stable branches.  And also there are other conntrack
flags that are simply ignored, not only inv and rpl.  These
are snat, dnat, rel, probably some other.  So, we need this
change in some form anyway.

Best regards, Ilya Maximets.

> 
> BR
> wenxu
> 
> 
> From: Ilya Maximets <i.maximets at ovn.org>
> Date: 2021-02-02 23:33:41
> To:  Paul Blakey <paulb at nvidia.com>,dev at openvswitch.org
> Cc:  Oz Shlomo <ozsh at nvidia.com>,i.maximets at ovn.org,Marcelo Leitner <mleitner at redhat.com>,wenxu <wenxu at ucloud.cn>
> Subject: Re: [ovs-dev] [PATCH 0/2] Add offload support for ct_state rpl and inv flags>On 2/2/21 1:47 PM, Paul Blakey wrote:
>>> Add offload support for ct_state rpl and inv flags.
>>
>>Hi.
>>
>>Since you're working on this, could you, please, review the following
>>patch:
>>  http://patchwork.ozlabs.org/project/openvswitch/patch/1610344573-15780-1-git-send-email-wenxu@ucloud.cn/
>>
>>It seems like current OVS just ignores all the flags that can not
>>be passed to TC and this doesn't look right.
>>
>>> 
>>> For example:
>>> ovs-ofctl del-flows br-ovs
>>> ovs-ofctl add-flow br-ovs arp,actions=normal
>>> ovs-ofctl add-flow br-ovs "table=0, ip,ct_state=-trk actions=ct(table=1,zone=5)"
>>> ovs-ofctl add-flow br-ovs "table=1, ip,ct_state=+trk+new actions=ct(zone=5, commit),normal"
>>> ovs-ofctl add-flow br-ovs "table=1, ip,ct_zone=5,ct_state=+trk+est+rpl actions=normal"
>>> ovs-ofctl add-flow br-ovs "table=1, ip,ct_zone=5,ct_state=+trk+est-rpl actions=normal"
>>> 
>>> Paul Blakey (2):
>>>   compat: Add TCA_FLOWER_KEY_CT_FLAGS_REPLY/INVALID definitions
>>>   netdev-offload-tc: Add support for ct_state rpl and inv flags
>>> 
>>>  acinclude.m4            |  6 +++---
>>>  include/linux/pkt_cls.h |  4 +++-
>>>  lib/netdev-offload-tc.c | 28 ++++++++++++++++++++++++++++
>>>  3 files changed, 34 insertions(+), 4 deletions(-)
>>> 
>>
> 
>