[ovs-dev] [PATCH] lib/tc: fix mpls bottom of stack bit mask reporting

Ilya Maximets i.maximets at ovn.org
Tue Feb 2 19:23:05 UTC 2021


On 11/25/20 10:51 AM, Eelco Chaudron wrote:
> Fix the reported back value of the bos mask used by the revalidator threads.
> 
> Fixes: 34b1695506f8 ("lib/tc: add single mpls match offload support")
> Reported-by: Marcelo Leitner <mleitner at redhat.com>
> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
> ---
>  lib/tc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/tc.c b/lib/tc.c
> index 8761304c9..af201b0c0 100644
> --- a/lib/tc.c
> +++ b/lib/tc.c
> @@ -517,7 +517,7 @@ nl_parse_flower_mpls(struct nlattr **attrs, struct tc_flower *flower)
>      if (attrs[TCA_FLOWER_KEY_MPLS_BOS]) {
>          bos = nl_attr_get_u8(attrs[TCA_FLOWER_KEY_MPLS_BOS]);
>          set_mpls_lse_bos(&flower->key.mpls_lse, bos);
> -        set_mpls_lse_ttl(&flower->mask.mpls_lse, 0xff);
> +        set_mpls_lse_bos(&flower->mask.mpls_lse, 0xff);
>      }
>  
>      if (attrs[TCA_FLOWER_KEY_MPLS_TC]) {
> 

Looks like a typo.  Thanks for the fix!

Applied to master and backported down to 2.11.

Best regards, Ilya Maximets.


More information about the dev mailing list