[ovs-dev] [PATCH ovn 2/2] rhel: Add systemd-units for ovn-ic services

0-day Robot robot at bytheb.org
Wed Feb 3 10:34:42 UTC 2021


Bleep bloop.  Greetings Numan Siddique, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 108 characters long (recommended limit is 79)
#165 FILE: rhel/usr_lib_systemd_system_ovn-ic-db.service:10:
#   Environment="OVN_IC_DB_OPTS=--db-ic-nb-create-insecure-remote=yes --db-ic-sb-create-insecure-remote=yes"

WARNING: Line is 92 characters long (recommended limit is 79)
#167 FILE: rhel/usr_lib_systemd_system_ovn-ic-db.service:12:
# Alternatively, you may specify environment variables in the file /etc/sysconfig/ovn-ic-db:

WARNING: Line is 96 characters long (recommended limit is 79)
#169 FILE: rhel/usr_lib_systemd_system_ovn-ic-db.service:14:
#   OVN_IC_DB_OPTS="--db-ic-nb-create-insecure-remote=yes --db-ic-sb-create-insecure-remote=yes"

WARNING: Line is 143 characters long (recommended limit is 79)
#203 FILE: rhel/usr_lib_systemd_system_ovn-ic.service:10:
#   Environment="OVN_IC_OPTS=--db-ic-nb-sock=/usr/local/var/run/ovn/ovn_ic_nb_db.sock --db-ic-sb-sock=/usr/local/var/run/ovn/ovn_ic_sb_db.sock"

WARNING: Line is 89 characters long (recommended limit is 79)
#205 FILE: rhel/usr_lib_systemd_system_ovn-ic.service:12:
# Alternatively, you may specify environment variables in the file /etc/sysconfig/ovn-ic:

WARNING: Line is 131 characters long (recommended limit is 79)
#207 FILE: rhel/usr_lib_systemd_system_ovn-ic.service:14:
#   OVN_IC_OPTS="--db-ic-nb-sock=/usr/local/var/run/ovn/ovn_ic_nb_db.sock --db-ic-sb-sock=/usr/local/var/run/ovn/ovn_ic_sb_db.sock"

Lines checked: 227, Warnings: 6, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list