[ovs-dev] [PATCH v3] vswitchd: update tc hwol docs regarding vswitchd restarts

Marcelo Ricardo Leitner marcelo.leitner at gmail.com
Thu Feb 4 02:16:44 UTC 2021


hw-offload is can actually be enabled without a restart. Then, once
enabled, a restart is needed in order to make the new value effective.

tc-policy, just like hw-offload, is protected by ovsthread_once_start()
in netdev_set_flow_api_enabled() and is only parsed when hw-offload is
enabled. So lets document that if hw-offload was already enabled
changing it requires a restart in order for it to have effect.

v2: include changes regarding the new understanding on hw-offload
v3: fixed warnings

Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
---
 vswitchd/vswitch.xml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 5b2a174ab813139d3f3253be47758d4bfb1beac3..83131b8f81502c34230e7e0b69fbb15a19721486 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -228,8 +228,8 @@
           Set this value to <code>true</code> to enable netdev flow offload.
         </p>
         <p>
-          The default value is <code>false</code>. Changing this value requires
-          restarting the daemon
+          The default value is <code>false</code>. Disabling this value requires
+          restarting the daemon.
         </p>
         <p>
           Currently Open vSwitch supports hardware offloading on
@@ -267,7 +267,9 @@
           <ref column="other_config" key="hw-offload"/> is enabled.
         </p>
         <p>
-          The default value is <code>none</code>.
+          The default value is <code>none</code>. Changing this value requires
+          restarting the daemon if
+          <ref column="other_config" key="hw-offload"/> was already enabled.
         </p>
       </column>
 
-- 
2.29.2



More information about the dev mailing list