[ovs-dev] [PATCH v4 2/5] netdev-offload: Add "offload-driver" other_config to specify offload driver

Toshiaki Makita toshiaki.makita1 at gmail.com
Fri Feb 5 12:44:51 UTC 2021


On 2021/02/05 18:00, Eli Britstein wrote:
> On 2/4/2021 9:18 PM, William Tu wrote:
>> On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita
>> <toshiaki.makita1 at gmail.com> wrote:
>>> The following commit will introduce another offload driver using XDP.
>>> When using afxdp netdev, both of TC and XDP will be supported, so let's
>>> add an other_config to specify which offload driver is preferable.
>>> When not specified and multiple offload drivers can be used, TC will be
>>> used if netdev supports it.
>>>
>>> Signed-off-by: Toshiaki Makita <toshiaki.makita1 at gmail.com>
>>> ---
>> The implementation looks good to me. Please also add "offload-driver"
>> to the vswitch.xml.
>>
>> About the interface, currently people are just setting
>> $ ovs-vsctl set Open_vSwitch . other_config:hw-offload=true
>> and assume tc hw offload for linux device and DPDK rte_flow for OVS-DPDK.
>>
>> Instead of boolean, another way is to
>> $ ovs-vsctl set Open_vSwitch . other_config:hw-offload={tc, rte_flow, xdp}
>> or just
>> $ ovs-vsctl set Open_vSwitch . other_config:offload={tc, rte_flow, xdp}
>>
>> Let's wait for others feedback.
> 
> Those are global configs. Currently the flow_api is determined by the port, which 
> can support mixed configurations (some ports with TC, and some with DPDK).
> 
> Both this proposal and the one in this commit will remove this support. How about 
> doing such "preferable" offload a port property (or at least bridge)?

Hi, thanks for the feedback.
Notice that the one in this commit does not remove mixed configurations support by 
default, i.e. if "offload-driver" is not specified,
- TC is used when TC is supported (e.g. afxdp port)
- rte_flow is used when TC is not supported but rte_flow is supported (dpdk port)

But yes, I guess it makes more sense to have the config as a port or bridge property.

Toshiaki Makita


More information about the dev mailing list