[ovs-dev] [PATCH ovn v10.1 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

[0-day Robot]

Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Comment with 'xxx' marker
#3724 FILE: northd/ovn-northd-ddlog.c:166:
        .cs = ovsdb_cs_create(database, 1 /* XXX */, &northd_cs_ops, ctx),

WARNING: Comment with 'xxx' marker
#4512 FILE: northd/ovn-northd-ddlog.c:954:
     * XXX If the transaction we're sending to the database fails, then

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#4565 FILE: northd/ovn-northd-ddlog.c:1007:
  --ovnnb-db=DATABASE       connect to ovn-nb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#4567 FILE: northd/ovn-northd-ddlog.c:1009:
  --ovnsb-db=DATABASE       connect to ovn-sb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#4569 FILE: northd/ovn-northd-ddlog.c:1011:
  --unixctl=SOCKET          override default control socket name\n\

WARNING: Line has trailing whitespace
#6344 FILE: northd/ovn_northd.dl:176:
    var l3dgw_port = peer.and_then(|p| p.router.l3dgw_port),    

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#9126 FILE: northd/ovn_northd.dl:2958:
     

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#12818 FILE: northd/ovn_northd.dl:6650:
    

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#13787 FILE: northd/ovn_northd.dl:7619:
    

WARNING: Line has trailing whitespace
#13988 FILE: northd/ovn_northd.dl:7820:
}    

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#13989 FILE: northd/ovn_northd.dl:7821:
                                          

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#13990 FILE: northd/ovn_northd.dl:7822:
 

Lines checked: 14607, Warnings: 22, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot