[ovs-dev] [PATCH ovn] binding: Fix potential crash when binding_seqno_run is skipped.

Dumitru Ceara dceara at redhat.com
Fri Feb 19 11:45:54 UTC 2021


On 2/19/21 10:48 AM, Numan Siddique wrote:
> On Thu, Feb 18, 2021 at 10:13 PM Dumitru Ceara <dceara at redhat.com> wrote:
>>
>> The prerequisite for binding_seqno_run() is that it has to be called
>> while there are valid SB and OVS transactions available.
>>
>> ovn-controller's main() function respects that but that means that there
>> is a small window (when OVS transaction is still in progress) when port
>> bindings might be deleted from the Southbound.
>>
>> When binding_seqno_run() was finally called, it was asserting that the
>> Port_bindings to still exist.  This check is too restrictive and the
>> solution is to just skip bindings that have become partial (i.e., no
>> SB.Port_Binding or no OVS.Interface).
>>
>> Fixes: 4d3cb42b076b ("binding: Set Logical_Switch_Port.up when all OVS flows are installed.")
>> Reported-at: https://bugzilla.redhat.com/1930030
>> Reported-by: Numan Siddique <numans at ovn.org>
>> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
> 
> Thanks Dumitru. I applied this patch to master.
> 

Thank you!



More information about the dev mailing list