[ovs-dev] [PATCH v1 8/9] conntrack: Do not log empty ct-sweep

[William Tu]

On Wed, Feb 17, 2021 at 8:34 AM Gaetan Rivet <grive at u256.net> wrote:
>
> Do not add noise to the DBG log for empty sweeps.
> Only log time taken when some connections were cleaned.
>
> Signed-off-by: Gaetan Rivet <grive at u256.net>
> Reviewed-by: Eli Britstein <elibr at nvidia.com>
> ---

LGTM
Acked-by: William Tu <u9012063 at gmail.com>


>  lib/conntrack.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index 1b21b79bd..e042683aa 100644
> --- a/lib/conntrack.c
> +++ b/lib/conntrack.c
> @@ -1574,8 +1574,10 @@ ct_sweep(struct conntrack *ct, long long now, size_t limit)
>      }
>
>  out:
> -    VLOG_DBG("conntrack cleanup %"PRIuSIZE" entries in %lld msec", count,
> -             time_msec() - now);
> +    if (count > 0) {
> +        VLOG_DBG("conntrack cleanup %"PRIuSIZE" entries in %lld msec", count,
> +                 time_msec() - now);
> +    }
>      return min_expiration;
>  }
>
> --
> 2.30.0
>