[ovs-dev] [PATCH ovn 2/3] lflow: Avoid matching on conntrack original tuple if possible.

Dumitru Ceara dceara at redhat.com
Wed Feb 24 14:59:21 UTC 2021


On 2/24/21 10:15 AM, Numan Siddique wrote:
> On Tue, Feb 23, 2021 at 6:50 PM Dumitru Ceara <dceara at redhat.com> wrote:
>>
>> Matching on ct_nw_dst()/ct_ipv6_dst()/ct_tp_dst() creates openflows
>> that often are not offloadable to hardware.  This was used for
>> detecting load balancer hairpin sessions.
>>
>> However, it can be avoided if ovn-northd stores the original
>> destination tuple in OVS registers.  For backwards compatibility,
>> during upgrade, fall back to matching on the conntrack original tuple.
>>
>> Signed-off-by: Dumitru Ceara <dceara at redhat.com>

Hi Numan,

> 
> Acked-by: Numan Siddique <numans at ovn.org>

Thanks for the review!

> 
> It will be great if you can enhance the test to pause northd, clear
> the lb option
> and make sure ovn-controller programs the flow in the old way.

The test I added in patch 1/3 does that already.  There's no change in 
this patch because in backwards compatibility mode flows in table=70 
look exactly the same as they did with patch 1/3.

> 
> Thanks
> Numan
> 

Thanks,
Dumitru



More information about the dev mailing list