[ovs-dev] [PATCH V2 01/14] netdev-offload: Add HW miss packet state recover API

[Eli Britstein]

On 2/25/2021 9:34 AM, Sriharsha Basavapatna wrote:
> On Tue, Feb 23, 2021 at 6:51 PM Eli Britstein <elibr at nvidia.com> wrote:
>>
>> On 2/23/2021 3:10 PM, Sriharsha Basavapatna wrote:
>>
>> On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein <elibr at nvidia.com> wrote:
>>
>> When the HW offload involves multiple flows, like in tunnel decap path,
>> it is possible that not all flows in the path are offloaded, resulting
>> in partial processing in HW. In order to proceed with rest of the
>> processing in SW, the packet state has to be recovered as if it was
>> processed in SW from the beginning. Add API for that.
>>
>> Can you be more specific/clear on what this API does ? What specific
>> packet state is this referring to and what is meant by recovering the
>> state here ? For example, if recovering  the packet state means to
>> check if the packet is encapsulated and to pop the tunnel header, then
>> it would make it clear to just state that.
>> Thanks,
>> -Harsha
>>
>> The state refers to the state provided by the HW. This patch introduces a generic API to support all cases.
>>
>> The case to pop in SW in case the info provided is that the packet is encapsulated is a private case.
> Private case ? IMO, the API/interface should provide sufficient
> information on what is meant by the state and recovery for each use
> case, starting with tunnel encapsulated packets for now.

This commit only adds a generic API, so its message is kept generic, 
even if currently in this series it will only be used for F1 and F2 miss.

The specifics of the recovery are in patch 5.

The documentation in rte_flow.h can be improved as well.


>>
>>