[ovs-dev] [PATCH ovn] binding: Do not clear container lbinding->pb when parent is deleted.

Dumitru Ceara dceara at redhat.com
Wed Jan 6 16:41:40 UTC 2021


On 1/6/21 3:09 PM, Numan Siddique wrote:
> On Wed, Jan 6, 2021 at 4:23 PM Dumitru Ceara <dceara at redhat.com> wrote:
>>
>> When a parent Port_Binding is deleted we shouldn't clear the children's
>> 'pb' field.  Container port bindings have their own Port_Binding SB
>> record so the child_lbinding->pb field should be cleared only when
>> their corresponding SB record is deleted.
>>
>> Whithout this fix when a parent Port_Binding "remove" followed by "add"
>> operations are received in the same iteration in ovn-controller,
>> consider_container_lport() can be called with "pb == NULL" causing a
>> crash.
>>
>> Fixes: 354bdba51abf ("ovn-controller: I-P for SB port binding and OVS interface in runtime_data.")
>> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
> 
> Thanks Dumitru for finding this issue. I applied this patch to master
> and backported upto branch 20.06.
> 
> Numan
> 

Thanks!



More information about the dev mailing list