[ovs-dev] [PATCH] ovs-lib: Fix call exit ovs-vswitchd and ovsdb-server failure

Ilya Maximets i.maximets at ovn.org
Mon Jan 11 11:07:23 UTC 2021


On 12/19/20 12:07 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian at huawei.com>
> 
> The ovn-controller need --restart argument. But ovs-vswitchd and
> ovsdb-server don't need argument. This also lead to exit failure.
> 
> Fixes: 7491caa37f3b ("ovn: Modify restart_controller in ovn-ctl to use --restart")
> Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> ---
>  utilities/ovs-lib.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in
> index f7e975674..ab38ece45 100644
> --- a/utilities/ovs-lib.in
> +++ b/utilities/ovs-lib.in
> @@ -273,7 +273,7 @@ stop_daemon () {
>                  case $action in
>                      EXIT)
>                          action "Exiting $1 ($pid)" \
> -                            ${bindir}/ovs-appctl -T 1 -t $rundir/$1.$pid.ctl exit $2
> +                            ${bindir}/ovs-appctl -T 1 -t $rundir/$1.$pid.ctl exit
>                          # The above command could have resulted in delayed
>                          # daemon segfault. And if a monitor is running, it
>                          # would restart the daemon giving it a new pid.
> 

OVN still uses this function, so we can't just remove the argument.
In OVS scripts I see no invocations of stop_daemon() where we have
a second argument, so there should be no issues.
What exactly the problem you have while calling this function for
OVS processes?

Best regards, Ilya Maximets.


More information about the dev mailing list