[ovs-dev] [PATCH v9 02/11] ovs-kmod-ctl: Load kernel module psample

Chris Mi cmi at nvidia.com
Wed Jan 13 01:37:54 UTC 2021


On 1/13/2021 3:34 AM, Eelco Chaudron wrote:
>
>
> On 15 Dec 2020, at 4:38, Chris Mi wrote:
>
>> Load kernel module psample to receive sampled packets from TC.
>> Before removing kernel module psample, remove act_sample first.
>>
>> Signed-off-by: Chris Mi <cmi at nvidia.com>
>> Reviewed-by: Eli Britstein <elibr at nvidia.com>
>> ---
>>  utilities/ovs-kmod-ctl.in | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/utilities/ovs-kmod-ctl.in b/utilities/ovs-kmod-ctl.in
>> index 19f100964..6fa945a83 100644
>> --- a/utilities/ovs-kmod-ctl.in
>> +++ b/utilities/ovs-kmod-ctl.in
>> @@ -28,6 +28,14 @@ for dir in "$sbindir" "$bindir" /sbin /bin 
>> /usr/sbin /usr/bin; do
>>  done
>>
>>  insert_mods () {
>> +    # Try loading psample kernel module.
>> +    modinfo psample > /dev/null 2>&1
>> +    if test $? = 0; then
>> +        action "Inserting psample module" modprobe psample
>> +    else
>> +        log_warning_msg "No psample module, can't offload sFlow action"
>> +    fi
>> +
>
> I don't think we need to load psample here, it will be automatically 
> loaded if we add the sample action. Same as for vxlan, gre, etc., etc.
Actually it's a little different. We need to initialize the psample 
netlink family and multicast group
when starting ovs daemon. If psample module is not loaded, we'll fail to 
initialize them.
>
>>      # Try loading openvswitch kernel module.
>>      action "Inserting openvswitch module" modprobe openvswitch
>>  }
>> @@ -95,6 +103,12 @@ remove_kmods() {
>>      if test -e /sys/module/vxlan; then
>>          action "Forcing removal of vxlan module" rmmod vxlan
>>      fi
>> +    if test -e /sys/module/act_sample; then
>> +        action "Forcing removal of act_sample module" rmmod act_sample
>> +    fi
>> +    if test -e /sys/module/psample; then
>> +        action "Forcing removal of psample module" rmmod psample
>> +    fi
>>  }
>>
>>  usage () {
>> -- 
>> 2.26.2
>



More information about the dev mailing list