[ovs-dev] [PATCH ovs 1/2] dpif-netdev: Fix the meter buckets overflow.

Ilya Maximets i.maximets at ovn.org
Wed Jan 13 23:30:22 UTC 2021


On 1/12/21 12:33 PM, xiangxia.m.yue at gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue at gmail.com>
> 
> When setting the meter rate to 4.3+Gbps, there is an overflow, the
> meters don't work as expected.
> 
> $ ovs-ofctl -O OpenFlow13 add-meter br-int "meter=1 kbps stats bands=type=drop rate=4294968"
> 
> Before the patch, the buckets of meters was stored in its burst_size
> of ofputil_meter_band. It was overflow when we set the rate to 4294968.
> This patch don't change the public API and structure. This patch remove
> the "up" from dp_meter_band, and introduce the type, rate to datapath's
> meter bands. Then datapath don't depend upper layer.
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
> ---

Hi.  Unit tests are failing with these patches applied:

990: dpif-netdev - meters                            FAILED (dpif-netdev.at:319)

Please, check them.

Best regards, Ilya Maximets.


More information about the dev mailing list