[ovs-dev] [PATCH v1 branch-2.14 1/2] acinclude: Strip out -march provided by DPDK.

Ilya Maximets i.maximets at ovn.org
Fri Jan 15 18:15:37 UTC 2021


On 1/15/21 6:37 PM, Ian Stokes wrote:
> DPDK flags may include -march. Forcing -march could be
> considered too heavy a requirement when users compile OVS from
> source and could override user provided options.
> 
> Resolve this by stripping -march from provided DPDK flags.
> 
> Signed-off-by: Ian Stokes <ian.stokes at intel.com>
> ---
>  acinclude.m4 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/acinclude.m4 b/acinclude.m4
> index 857067a88..14fe4218a 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -436,6 +436,9 @@ AC_DEFUN([OVS_CHECK_DPDK], [
>      if test "$DPDK_AUTO_DISCOVER" = "false"; then
>        OVS_LDFLAGS="$OVS_LDFLAGS -L$DPDK_LIB_DIR"
>      fi
> +    # Force in pkg-config since this could override user-specified options.

Seems like some word is missing in this sentence.

> +    # It's enough to have -mssse3 to build with DPDK headers.
> +    DPDK_INCLUDE=$(echo "$DPDK_INCLUDE" | sed 's/-march=[[^ ]]*//g')
>      OVS_CFLAGS="$OVS_CFLAGS $DPDK_INCLUDE"
>      OVS_ENABLE_OPTION([-mssse3])
>  
> 


More information about the dev mailing list