[ovs-dev] [PATCH v3 0/2] add port-based ingress policing based packet-per-second rate-limiting

Simon Horman simon.horman at netronome.com
Fri Jul 2 05:23:31 UTC 2021


On Thu, Jul 01, 2021 at 09:47:35PM +0200, Ilya Maximets wrote:
> On 7/1/21 9:17 PM, Simon Horman wrote:
> > On Tue, Jun 29, 2021 at 08:17:04AM -0700, Marcelo Ricardo Leitner wrote:
> >> On Wed, Jun 23, 2021 at 03:47:45PM +0200, Simon Horman wrote:
> >>> On Wed, Jun 09, 2021 at 11:52:07AM +0200, Simon Horman wrote:
> >>>> Hi,
> >>>>
> >>>> this short test adds support for add port-based ingress policing based
> >>>> packet-per-second rate-limiting. This builds on existing support for
> >>>> byte-per-second rate limiting.
> >>>>
> >>>> Changes since v2
> >>>>
> >>>> * Remove the for loop in function nl_msg_put_act_police()
> >>>> * Remove unused enum definition for qos type
> >>>> * Define 1 kpkts as 1000 packets rather than 1024 packets
> >>>> * Update the description for the new item in ovsdb
> >>>> * Fix some format warnings according robot's comments
> >>>>
> >>>> Changes between v1 and v2
> >>>> * Correct typo: s/comsume/consume/
> >>>
> >>> Hi Marcelo,
> >>>
> >>> could I trouble you for a review of this series.
> >>> I believe it addresses the issues that you raised in v2.
> >>
> >> Hi Simon,
> >>
> >> Yes, it does, thanks.
> >>
> >> I'd like to run some tests and get more acquainted with rate limiting
> >> on OVS before adding a Reviewed-by tag, but I couldn't do it so far
> >> and now I'm not sure I can do it this week. Anyhow, lets not have the
> >> merge blocked on this, unless you really want to. :-)
> >> I probably can get to this next week, FWIW.
> > 
> > Thanks Marcelo,
> > 
> > I've gone ahead and applied this series.
> > 
> > Please do let us know if there are any problems you find,
> > we're more than happy to discuss follow-up.
> 
> One follow up could be to add NEWS entry, as this is a user-visible change. :)
> 
> Best regards, Ilya Maximets.

Thanks Ilya, will do.


More information about the dev mailing list