[ovs-dev] [PATCH v2 1/7] dpif-netdev: Rework rxq scheduling code.

Pai G, Sunil sunil.pai.g at intel.com
Mon Jul 5 17:01:45 UTC 2021


Hi Kevin, 


> This reworks the current rxq scheduling code to break it into more generic
> and reusable pieces.
> 
> The behaviour does not change from a user perspective, except the logs are
> updated to be more consistent.
> 
> From an implementation view, there are some changes with mind to adding
> functionality and reuse in later patches.
> 
> The high level reusable functions added in this patch are:
> - Generate a list of current numas and pmds
> - Perform rxq scheduling into the list
> - Effect the rxq scheduling assignments so they are used
> 
> The rxq scheduling is updated to handle both pinned and non-pinned rxqs in
> the same call.
> 
> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
> ---
>  lib/dpif-netdev.c | 557 +++++++++++++++++++++++++++++++++++++------
> ---
>  tests/pmd.at      |   2 +-
>  2 files changed, 450 insertions(+), 109 deletions(-)
> 

Looks good to me.
Once the unit tests are resolved/fixed in github actions , I'll be happy to ack.

Thanks and regards,
Sunil


More information about the dev mailing list