[ovs-dev] [PATCH v2 3/7] dpif-netdev: Sort PMD list by core id for rxq scheduling.

[Pai G, Sunil]

Hi Kevin , 


> -----Original Message-----
> From: Kevin Traynor <ktraynor at redhat.com>
> Sent: Friday, July 2, 2021 4:55 AM
> To: dev at openvswitch.org
> Cc: david.marchand at redhat.com; Pai G, Sunil <sunil.pai.g at intel.com>;
> cfontain at redhat.com; Kevin Traynor <ktraynor at redhat.com>
> Subject: [PATCH v2 3/7] dpif-netdev: Sort PMD list by core id for rxq
> scheduling.
> 
> The list of PMDs is round robined through for the selection when assigning an
> rxq to a PMD. The list is based on a hash map, so there is no defined order.
> 
> It means that in cases where there is no traffic or traffic patterns do not
> change, the same set of PMDs may get assigned different rxqs for no reason
> other than how they are stored in the hash map.
> 
> This can be easily changed to make the PMDs be assigned the same rxqs by
> sorting the PMDs by core id after they are extracted from the hmap.
> 
> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
> ---
>  lib/dpif-netdev.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 

LGTM.
Will ack once the GHA is all green.

Thanks and regards,
Sunil