[ovs-dev] [PATCH 1/1] match: do not print "igmp" match keyword

Adrian Moreno amorenoz at redhat.com
Tue Jul 6 06:25:59 UTC 2021



On 7/5/21 4:15 PM, Flavio Leitner wrote:
> 
> Hi,
> 
> On Wed, Jun 30, 2021 at 05:43:54PM +0200, Adrian Moreno wrote:
>> The match keyword "igmp" is not supported in ofp-parse, which means
>> that flow dumps cannot be restored. This patch prints the igmp match
>> in the accepted format (ip,nw_proto=2) and adds a test.
> 
> I raised concerns about changing the output and break scripts in
> the past.  However, it seems not removing the keyword also cause
> issues, so I am not opposing to remove the igmp keyword anymore.
> 
> Acked-by: Flavio Leitner <fbl at sysclose.org>
> 

Thanks Flavio. Do you think this is an acceptable solution also for stable branches?

If not, how about replacing the flows in ovs-save so that upgrades of stable
branches work fine?

Thanks.
-- 
Adrián Moreno



More information about the dev mailing list