[ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

Amber, Kumar kumar.amber at intel.com
Tue Jul 6 15:06:48 UTC 2021


Hi Eelco ,


Here is the diff  vor v6 vs v5 :

Patch 1 : 

diff --git a/lib/dpif-netdev-private-extract.c b/lib/dpif-netdev-private-extract.c
index 1aebf3656d..4987d628a4 100644
--- a/lib/dpif-netdev-private-extract.c
+++ b/lib/dpif-netdev-private-extract.c
@@ -233,7 +233,7 @@ dpif_miniflow_extract_autovalidator(struct dp_packet_batch *packets,
                                     uint32_t keys_size, odp_port_t in_port,
                                     struct dp_netdev_pmd_thread *pmd_handle)
 {
-    const size_t cnt = dp_packet_batch_size(packets);
+    const uint32_t cnt = dp_packet_batch_size(packets);
     uint16_t good_l2_5_ofs[NETDEV_MAX_BURST];
     uint16_t good_l3_ofs[NETDEV_MAX_BURST];
     uint16_t good_l4_ofs[NETDEV_MAX_BURST];
@@ -247,7 +247,7 @@ dpif_miniflow_extract_autovalidator(struct dp_packet_batch *packets,
         atomic_uintptr_t *pmd_func = (void *)&pmd->miniflow_extract_opt;
         atomic_store_relaxed(pmd_func, (uintptr_t) default_func);
         VLOG_ERR("Invalid key size supplied, Key_size: %d less than"
-                 "batch_size: %ld", keys_size, cnt);
+                 "batch_size: %d", keys_size, cnt);
         return 0;
     }

Patch 7 :

AT_SKIP_IF([! pip3 list | grep scapy], [], [])

> -----Original Message-----
> From: Eelco Chaudron <echaudro at redhat.com>
> Sent: Tuesday, July 6, 2021 8:04 PM
> To: Ferriter, Cian <cian.ferriter at intel.com>
> Cc: ovs-dev at openvswitch.org; fbl at sysclose.org; i.maximets at ovn.org; Van
> Haaren, Harry <harry.van.haaren at intel.com>; Amber, Kumar
> <kumar.amber at intel.com>; Stokes, Ian <ian.stokes at intel.com>
> Subject: Re: [v6 00/11] MFEX Infrastructure + Optimizations
> 
> Cian,
> 
> Which patches change, so I know where to update my review? None of the
> commit messages show v6 changes.
> 
> //Eelco
> 

Regards
Amber


More information about the dev mailing list