[ovs-dev] [v5 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

[Van Haaren, Harry]

> -----Original Message-----
> From: Eelco Chaudron <echaudro at redhat.com>
> Sent: Wednesday, July 7, 2021 7:45 AM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: Ferriter, Cian <cian.ferriter at intel.com>; ovs-dev at openvswitch.org;
> fbl at sysclose.org; i.maximets at ovn.org; Amber, Kumar <kumar.amber at intel.com>;
> Stokes, Ian <ian.stokes at intel.com>
> Subject: Re: [v5 01/11] dpif-netdev: Add command line and function pointer for
> miniflow extract
> 
> 
> 
> On 6 Jul 2021, at 17:32, Van Haaren, Harry wrote:

<snip previous discussion>

> > Agree to implement & merge the above?
> 
> You are right, and your suggestion eases the general use case but makes the pkt_cnt
> option hard to use, as you have to execute the command for each PMD.
> 
> I was looking at other commands with the same problem, and they use a -pmd
> keyword approach. Some examples:
> 
>   dpif-netdev/pmd-rxq-show [-pmd core] [dp]
>   dpif-netdev/pmd-stats-clear [-pmd core] [dp]
>   dpif-netdev/pmd-stats-show [-pmd core] [dp]
> 
> Guess we can do the same here:
> 
>   dpif-netdev/miniflow-parser-set [-pmd core] miniflow_implementation_name
> [pkt_cnt]

Ah, yes, that's better than the other suggestions;
1) Consistency for power users with how -pmd thread can be set
2) Shortest possible command for simplest/most-common usage (just set study)

Thanks for input, v7 targeting this command method!

> > <snip remainder of feedback>.
> >
> > Regards, -Harry