[ovs-dev] [PATCH v6 ovn 0/4] respin CoPP series

Lorenzo Bianconi lorenzo.bianconi at redhat.com
Fri Jul 9 09:11:48 UTC 2021


On Jul 08, Ben Pfaff wrote:
> On Thu, Jul 08, 2021 at 06:40:01PM +0200, Lorenzo Bianconi wrote:
> > This series respin CoPP support introduced here [0] by Dumitru rebasing on top
> > of ovn master branch and adding some missing meters (e.g. bfd or acl reject).
> > The main goal of this series is to continue the discussion about the proposed
> > approach and to align on CMS APIs.
> > For the moment DDLog is not supported yet and it will be added in a subsequent
> > series.
> 
> I wrote a ddlog implementation on top of v7 and pushed it here:
> https://github.com/blp/ovs-reviews/commits/COPP-v7%2Bddlog
> 
> There are just two patches on top of yours.  I'd prefer if the first one
> "ovn-northd-ddlog: Optimize AggregatedFlow rules." be inserted somewhere
> in your series and if the second one "Implement CoPP for DDlog." were
> squashed in the right place in your series.

Hi Ben,

thx a lot for the series.
Compiling the code I have this error:

error: module 'copp' imported by northd/ovn_northd.dl not found. Paths searched:
/home/lorenzo/workspace/ovn/northd/copp.dl
/home/lorenzo/workspace/ddlog-v0.38/lib/copp.dl

I think you have not committed copp.dl, correct?

Regards,
Lorenzo

> 
> It occurred to me that the new column controller_meter gets populated
> pretty predictably: if something in the flow will make ovn-controller
> process a packet, then it gets set to whatever that is.  As a result, I
> don't know whether it's necessary to have the column.  ovn-controller
> could just recognize that a particular flow would cause it to process a
> packet (it knows that, of course) and then assign that packet to the
> appropriate meter, if it exists.
> 


More information about the dev mailing list