[ovs-dev] [PATCH 2/2] netdev-offload-dpdk: Fix vxlan vni cast-align warnings

Van Haaren, Harry harry.van.haaren at intel.com
Mon Jul 12 08:37:53 UTC 2021


> -----Original Message-----
> From: Eli Britstein <elibr at nvidia.com>
> Sent: Sunday, July 11, 2021 6:15 AM
> To: dev at openvswitch.org; Ilya Maximets <i.maximets at ovn.org>; Van Haaren,
> Harry <harry.van.haaren at intel.com>
> Cc: Gaetan Rivet <gaetanr at nvidia.com>; Majd Dibbiny <majd at nvidia.com>; Eli
> Britstein <elibr at nvidia.com>
> Subject: [PATCH 2/2] netdev-offload-dpdk: Fix vxlan vni cast-align warnings
> 
> Compiling with -Werror and -Wcast-align has errors like:
> 
> lib/netdev-offload-dpdk.c: In function 'dump_flow_pattern':
> lib/netdev-offload-dpdk.c:385:38: error: cast increases required alignment
>     of target type [-Werror=cast-align]
>   385 |    ntohl(*(ovs_be32 *) vxlan_spec->vni) >> 8,
>       |           ^
> 
> Fix them.
> 
> Reported-by: Harry Van Haaren <harry.van.haaren at intel.com>
> Fixes: 4e432d6f8128 ("netdev-offload-dpdk: Support tnl/push using vxlan encap
> attribute.")
> Fixes: e098c2f966cb ("netdev-dpdk-offload: Add vxlan pattern matching function.")
> Signed-off-by: Eli Britstein <elibr at nvidia.com>

Thanks Eli, tested compilation, and the cast-align issue is resolved for master branch with
these the patches in this series. I cannot test functionality here, so just compile tested.

Series-Tested-by: Harry van Haaren <harry.van.haaren at intel.com>



More information about the dev mailing list