[ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

Aaron Conole aconole at redhat.com
Mon Jul 12 16:01:28 UTC 2021


Aaron Conole <aconole at redhat.com> writes:

> Ilya Maximets <i.maximets at ovn.org> writes:
>
>> On 7/12/21 5:10 PM, David Marchand wrote:
>>> On Mon, Jul 12, 2021 at 4:43 PM Ilya Maximets <i.maximets at ovn.org> wrote:
>>>>>> ovsrobot has issues with reporting the status right now, but this
>>>>>> patch fails the build in GHA:
>>>>>>   https://github.com/ovsrobot/ovs/actions/runs/1021787643
>>>>>
>>>>> Thanks for linking on results.
>>>>>
>>>>> I've spot-checked a bunch of the failing builds, and found 2 fixable code issues.
>>>>> A few of the CI run's I can't find/explain the error, but I don't know of a good
>>>>> way to "jump to the error" line, am I missing a trick, or is scrolling the whole
>>>>> compiler output and checking errors the best method?
>>>>
>>>> typing 'error:' in the 'Search logs' field, usually gets you
>>>> to the actual error faster, but, unfortunately, scrolling is
>>>> the most reliable option.
>>> 
>>> GHA ui jumps at the last line of a failing step, but the problem is
>>> that, in OVS, we dump all logs which adds a lot of noise.
>>> 
>>> We could stop dumping them, since those logs are attached to the job
>>> as an archive.
>>> Like what is done in DPDK.
>>> http://git.dpdk.org/dpdk/tree/.ci/linux-build.sh#n3
>>> 
>>> WDYT?
>>
>> Yes, that is good thing to do.  We didn't do that because of
>> Travis CI, where we have no artifacts collected.
>
> +1 - we should bend over backwards to make things easier on Travis CI to
> the detriment of other platforms.

And by this, I mean the opposite - we should *NOT* bend over backwards
to make things easier on Travis CI.

>> But yes, checking for [ -n "$GITHUB_WORKFLOW" ] is a solution.
>>
>> Best regards, Ilya Maximets.



More information about the dev mailing list