[ovs-dev] [PATCH v13 07/11] test/sytem-dpdk: Add unit test for mfex autovalidator

[Van Haaren, Harry]

> -----Original Message-----
> From: Flavio Leitner <fbl at sysclose.org>
> Sent: Thursday, July 15, 2021 4:26 PM
> To: Amber, Kumar <kumar.amber at intel.com>
> Cc: ovs-dev at openvswitch.org; echaudro at redhat.com; i.maximets at ovn.org; Van
> Haaren, Harry <harry.van.haaren at intel.com>; Ferriter, Cian
> <cian.ferriter at intel.com>; Stokes, Ian <ian.stokes at intel.com>
> Subject: Re: [PATCH v13 07/11] test/sytem-dpdk: Add unit test for mfex
> autovalidator
> 
> On Thu, Jul 15, 2021 at 06:12:13PM +0530, kumar Amber wrote:

<snip patch>

> > +
> > +AT_CHECK([ovs-appctl dpif-netdev/miniflow-parser-set -pmd 21 study], [0], [dnl
> > +Miniflow extract implementation set to study, on pmd thread 21, studying 128
> packets.
> > +])
> 
> This one actually fails to me because the pmd id is not valid:

Ah ok.

> --- /dev/null   2021-07-14 14:56:03.508411934 -0400
> +++
> /ovs/tests/system-dpdk-testsuite.dir/at-groups/8/stderr
> 2021-07-15 10:59:47.441060921 -0400
> @@ -0,0 +1,2 @@
> +Error: Miniflow parser not changed, PMD thread 21 not in use, pass a valid pmd
> thread ID.
> +ovs-appctl: ovs-vswitchd: server returned an error
> 
> Most probably the other ones relying on -pmd 21 will fail as well.

Interesting, same as before.  

> The valid PMD id here was 11. I think the test needs to find out the
> PMD id first, then issue the command.

Yes, this can be resolved by just setting the OVS PMD mask on startup.
(By choosing that startup coremask to be 0xC we require a minimum 4 core machine)
The valid tests core ids have been updated to "-pmd 3" as included by 0xC mask.

+AT_CHECK([ovs-vsctl --no-wait set Open_vSwitch . other_config:pmd-cpu-mask=0xC])

Fix included in v14.

> fbl

Thanks for feedback. Regards, -Harry

<snip remainder>