[ovs-dev] [PATCH v14 10/11] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

[Eelco Chaudron]

On 16 Jul 2021, at 10:49, Stokes, Ian wrote:

>> On Thu, Jul 15, 2021 at 09:36:16PM +0530, kumar Amber wrote:
>>> From: Harry van Haaren <harry.van.haaren at intel.com>
>>>
>>> This commit adds AVX512 implementations of miniflow extract.
>>> By using the 64 bytes available in an AVX512 register, it is
>>> possible to convert a packet to a miniflow data-structure in
>>> a small quantity instructions.
>>>
>>> The implementation here probes for Ether()/IP()/UDP() traffic,
>>> and builds the appropriate miniflow data-structure for packets
>>> that match the probe.
>>>
>>> The implementation here is auto-validated by the miniflow
>>> extract autovalidator, hence its correctness can be easily
>>> tested and verified.
>>>
>>> Note that this commit is designed to easily allow addition of new
>>> traffic profiles in a scalable way, without code duplication for
>>> each traffic profile.
>>>
>>> Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
>>> Acked-by: Eelco Chaudron <echaudro at redhat.com>
>>>
>>> ---
>>
>> Acked-by: Flavio Leitner <fbl at sysclose.org>
>
> Thanks Flavio,
>
> @echaudro at redhat.com are these changes OK with you and can we add an ACK? (sorry to push on this, given the deadline today to branch we'd like to merge, there are a few other patch series I'd like to rebase on it and merge also so would be great to close this off if there are no objections).
>
> Thanks
> Ian

Hi Ian,

Only some comments on patches 3 and 6, see comments in the respective patch email.

If you do fix them on merge, make sure the indentation changes do not make it grow over 80 chars.

Cheers,

Eelco