[ovs-dev] [PATCH v14 07/11] test/sytem-dpdk: Add unit test for mfex autovalidator

Ilya Maximets i.maximets at ovn.org
Fri Jul 16 14:46:32 UTC 2021


On 7/15/21 6:06 PM, kumar Amber wrote:
> From: Kumar Amber <kumar.amber at intel.com>
> 
> Tests:
>   6: OVS-DPDK - MFEX Autovalidator
>   7: OVS-DPDK - MFEX Autovalidator Fuzzy
>   8: OVS-DPDK - MFEX Configuration
> 
> Added a new directory to store the PCAP file used
> in the tests and a script to generate the fuzzy traffic
> type pcap to be used in fuzzy unit test.
> 
> Signed-off-by: Kumar Amber <kumar.amber at intel.com>
> Acked-by: Flavio Leitner <fbl at sysclose.org>
> 
> ---
> v14:
> - include more neagtive tests in configuration
> - added core mask for the test
> v13:
> - fix -v in the command
> - added the configuration test case and supporting doc update
> v12:
> - change skip paramter for unit test
> v11:
> - fix comments from Eelco
> v7:
> - fix review comments(Eelco)
> v5:
> - fix review comments(Ian, Flavio, Eelco)
> - remove sleep from first test and added minor 5 sec sleep to fuzzy
> ---
> ---
>  Documentation/topics/dpdk/bridge.rst |  56 ++++++++++
>  tests/.gitignore                     |   1 +
>  tests/automake.mk                    |   6 +
>  tests/mfex_fuzzy.py                  |  33 ++++++
>  tests/pcap/mfex_test.pcap            | Bin 0 -> 416 bytes
>  tests/system-dpdk.at                 | 160 +++++++++++++++++++++++++++
>  6 files changed, 256 insertions(+)
>  create mode 100755 tests/mfex_fuzzy.py
>  create mode 100644 tests/pcap/mfex_test.pcap
> 

<snip>

> diff --git a/tests/mfex_fuzzy.py b/tests/mfex_fuzzy.py
> new file mode 100755
> index 000000000..5b056bb48
> --- /dev/null
> +++ b/tests/mfex_fuzzy.py
> @@ -0,0 +1,33 @@
> +#!/usr/bin/python3
> +try:
> +    from scapy.all import RandMAC, RandIP, PcapWriter, RandIP6, RandShort, fuzz
> +    from scapy.all import IPv6, Dot1Q, IP, Ether, UDP, TCP
> +except ModuleNotFoundError as err:
> +    print(err + ": Scapy")
> +import sys


Hey, Ian and others.

This change broke flake8-check on systems with python < 3.6:

../../tests/mfex_fuzzy.py:5:8: F821 undefined name 'ModuleNotFoundError'
2653Makefile:5826: recipe for target 'flake8-check' failed

Please, replace with something more backward compatible. (ImportError ?)

Best regards, Ilya Maximets.


More information about the dev mailing list